This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: gij support for slashes in class names


>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:

Tom> gij does not support slashes in class name arguments.  This patch
Tom> adds support for this syntax, which is convenient when using
Tom> command-line completion.

Tom> OK to commit?

Yes, thanks.

I think this should be documented as an extension in the gij texinfo
page.

Tom> +      // Handle slashes in class names.
Tom> +      int name_length = strlen (argv[i]);
Tom> +      for (int c = 0; c < name_length; c++)
Tom> +        {
Tom> +          char* arg = (char*) argv[i];

This is kind of weird.  If you really want a cast, use const_cast<>
(see earlier in the file).  But I don't see why argv is const
anyway... IMO you could just remove the const and the existing
const_cast<>.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]