This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: gij support for slashes in class names
- From: Tom Tromey <tromey at redhat dot com>
- To: Thomas Fitzsimmons <fitzsim at redhat dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Wed, 31 May 2006 12:13:58 -0500
- Subject: Re: Patch: gij support for slashes in class names
- References: <447CD510.9050708@redhat.com>
- Reply-to: tromey at redhat dot com
>>>>> "Tom" == Thomas Fitzsimmons <fitzsim@redhat.com> writes:
Tom> gij does not support slashes in class name arguments. This patch
Tom> adds support for this syntax, which is convenient when using
Tom> command-line completion.
Tom> OK to commit?
Yes, thanks.
I think this should be documented as an extension in the gij texinfo
page.
Tom> + // Handle slashes in class names.
Tom> + int name_length = strlen (argv[i]);
Tom> + for (int c = 0; c < name_length; c++)
Tom> + {
Tom> + char* arg = (char*) argv[i];
This is kind of weird. If you really want a cast, use const_cast<>
(see earlier in the file). But I don't see why argv is const
anyway... IMO you could just remove the const and the existing
const_cast<>.
Tom