This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [patch] include/posix.h

From: Tom Tromey <tromey at redhat dot com>
To: Andreas Tobler <toa at pop dot agri dot ch>
Cc: Java Patches <java-patches at gcc dot gnu dot org>, John David Anglin <dave at hiauly1 dot hia dot nrc dot ca>
Date: 23 May 2006 18:36:15 -0600
Subject: Re: [patch] include/posix.h
References: <446E43A3.3080507@pop.agri.ch> <m3bqtpycv4.fsf@localhost.localdomain> <447366D3.5030905@pop.agri.ch>
Reply-to: tromey at redhat dot com

>>>>> "Andreas" == Andreas Tobler <toa@pop.agri.ch> writes:

Andreas> Well, this does not help if Boolean.h is included before such magic
Andreas> system headers which define TRUE and FALSE again.

Yeah.  However, any ordering will have an associated potential
failure mode, afaics.

Andreas> In our case sys/rw_lock.h, the file where this (re)-definition
Andreas> happens, is included after Boolean.h, implicitely. So I tend to agree
Andreas> with Dave that the workaround he proposes is probably the best one in
Andreas> regard of effort and gain.

That patch also looked fine to me.  Feel free to check it in.

Tom

Follow-Ups:
- Re: [patch] include/posix.h
  - From: John David Anglin

References:
- [patch] include/posix.h
  - From: Andreas Tobler
- Re: [patch] include/posix.h
  - From: Tom Tromey
- Re: [patch] include/posix.h
  - From: Andreas Tobler

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]