Re: Patch: RFC: PR 27352

[Bryce McKinlay <mckinlay at redhat dot com>]

Tom Tromey wrote:
> Bryce> This patch fixes PR 27352 by adding a getClassLoaderInternal()
> Bryce> implementation in Java. This is a shortcut implementation of
> Bryce> getClassLoader() that bypasses redundant security manager
> Bryce> checks. getClassLoaderInternal() was already used from natClass.cc,
> Bryce> but it couldn't be used from Java code because it was only defined in
> Bryce> Class.h.
>
> Actually, why is this needed?  According to the PR Andrew already
> checked in a fix.  And according to the test case this fix already
> works.
>   

Andrew's patch was to rewrite forName() and getClassLoader() invocations 
to add a class argument. Mostly this is for performance, since it avoids 
having to do the stack trace. It fixed 27352 as a side-effect, but only 
for newly-compiled native code. Old BC code and interpreted code will 
still hit the bug - we need to fix it for all cases. There will be a 
performance improvement here, too.

Bryce