This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: patch/RFC/RFT detect ICE in libjava testsuite


>>>>> "David" == David Daney <ddaney@avtrex.com> writes:

David> I tried the patch, and it does indeed seem to produce FAILs when the
David> compiler ICEs and the xfail file contains 'shouldfail'.  However I
David> have been unsuccessful supressing the FAIL messages.

'shouldfail' has a specific meaning, namely that the test contains
invalid code and we are checking to make sure the compiler rejects it.

In this situation we always want an ICE to fail, since this means that
the compiler failed in the wrong way.

For a while we put in test cases before fixing the bug, so there is
all this xfail stuff around.  These days I think we're more likely to
simply not check in a test case until we're ready to actually fix the
problem.

So, I think something like 'xfail-shouldfail' probably isn't really
needed.  We can just hold the test case in bugzilla until we're ready.

What do you think?

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]