This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: FYI: libffi usage & ARM build fix
- From: Tom Tromey <tromey at redhat dot com>
- To: Robert Schuster <theBohemian at gmx dot net>
- Cc: java-patches at gcc dot gnu dot org
- Date: 03 Feb 2006 09:42:39 -0700
- Subject: Re: FYI: libffi usage & ARM build fix
- References: <43E364A0.40705@gmx.net>
- Reply-to: tromey at redhat dot com
>>>>> "Robert" == Robert Schuster <theBohemian@gmx.net> writes:
Robert> + ffi_closure *closure = (ffi_closure *) _Jv_Malloc( sizeof( ffi_closure ));
In our coding style, there are no spaces after '(' or before ')'.
Please fix this, it is everywhere in your patch.
Robert> + if (ffi_prep_cif (
Robert> + cif, FFI_DEFAULT_ABI, 1, &ffi_type_void, arg_types) == FFI_OK
Robert> + && (ffi_prep_closure (
Robert> + closure, cif, _Jv_ThrowNoClassDefFoundErrorTrampoline,
Robert> + class_name) == FFI_OK))
These lines are split incorrectly. Splitting happens after a ',',
not after a '('.
Tom