This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
RE: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR classpath/24104 et al. ...
- From: "Jeroen Frijters" <jeroen at sumatra dot nl>
- To: "David Daney" <ddaney at avtrex dot com>,"Java Patch List" <java-patches at gcc dot gnu dot org>,"Classpath Patches" <classpath-patches at gnu dot org>
- Date: Wed, 12 Oct 2005 07:08:51 +0200
- Subject: RE: [cp-patches] [PATCH] Fix PR classpath/24086, PR classpath/24091, PR classpath/24104 et al. ...
David Daney wrote:
> This is the new version of my HTTP patch. It keeps promoting (near)
> silence from the approvers, and I keep finding and fixing new bugs.
> Also it has been about a week and I fixed another bug, so I thought I
> would post the current version.
Thanks for this rewrite. I reviewed the patch and it looks good. I have
two small nitpicks:
+ if (-1 == r)
In Java this isn't really needed (as you can't accidentally do an assign
here anyway), so it is uncommon to put the constant first.
LimitedLengthInputStream shouldn't have a finalize().
> OK to commit?
I vote yes.
Regards,
Jeroen