Re: [gcjx] Patch: FYI: compiling gcj front end

[Tom Tromey <tromey at redhat dot com>]

>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:

Ranjit> I think you refreshed your tree just in the window it took
Ranjit> me to apply my "gcjx" patch followed by the "gcc/java" patch. :-/

Actually my patch was against tree.cc -- both the .hh and the .cc file
had to be touched in this case.

Ranjit> I took the latter option not only because
Ranjit> it was simpler to implement and I am lazy, but also because
Ranjit> I was not totally sure if tree walkers were not supposed to
Ranjit> modify the tree while walking.

Yeah.  In general I think the visitors shouldn't be modifying the
model, but in practice there may be situations where it is needed.
Honestly I'm not certain :-(, at least not without doing some
investigation.

Ranjit> I now realise that visiting these "model_method *" or "model_field *"
Ranjit> would be redundant and we could just print their names in the
Ranjit> pretty-printer. I was therefore going to add back the "const"
Ranjit> qualifiers, but now I see that you're actually using this to
Ranjit> remove const_cast from some places.

Ranjit> So I don't think I should add back these qualifiers, no?

Let's leave them off.

Tom