This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [gcjx] RFC/RFA: A Simple Pretty-Printer for the AST (WIP)
- From: Tom Tromey <tromey at redhat dot com>
- To: Ranjit Mathew <rmathew at gmail dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: 08 Oct 2005 16:36:34 -0600
- Subject: Re: [gcjx] RFC/RFA: A Simple Pretty-Printer for the AST (WIP)
- References: <di93uv$he2$1@sea.gmane.org>
- Reply-to: tromey at redhat dot com
>>>>> "Ranjit" == Ranjit Mathew <rmathew@gmail.com> writes:
Ranjit> I am attaching a work-in-progress implementation of a simple
Ranjit> pretty-printer for the AST.
Ranjit> Comments? OK to apply?
I think it is fine. Thanks for doing this.
Feel free to check in future dumper changes with just an 'fyi' note.
Ranjit> + modifier_t mods = field->get_modifiers ();
Ranjit> + if ((mods & ACC_PUBLIC) != 0)
Ranjit> + out << " PUBLIC";
Maybe a helper function to print this stuff?
Not all of the modifiers in modifier.hh are actually used in gcjx
yet, but that is only because I haven't yet implemented bridge
methods and whatnot.
You may also want to \-quote "weird" characters in string literals.
Kind of a pain though.
Tom