This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] gimplifying leaves reference to the BLOCK's body
- From: Tom Tromey <tromey at redhat dot com>
- To: Andrew Pinski <pinskia at physics dot uc dot edu>
- Cc: patch Patches <gcc-patches at gcc dot gnu dot org>, GCJ Patches <java-patches at gcc dot gnu dot org>
- Date: 06 Sep 2005 08:08:37 -0600
- Subject: Re: [PATCH] gimplifying leaves reference to the BLOCK's body
- References: <9e49a0e69cbb0c3b7d70c1966f7739c5@physics.uc.edu>
- Reply-to: tromey at redhat dot com
>>>>> "Andrew" == Andrew Pinski <pinskia@physics.uc.edu> writes:
Andrew> * java-gimplify.c (java_gimplify_block): NULL out the old BLOCK's
Andrew> BLOCK_EXPR_BODY before returning the new BIND_EXPR.
Andrew> + BLOCK_EXPR_BODY (java_block) = NULL_TREE;
This seems reasonable to me, but either Per or Andrew will have to
approve. Perhaps a comment explaining why we're doing this would be
helpful.
Just to clarify, we only collect more if later passes determine that
code in the block is dead. Currently in this situation, the dead
trees will linger since we still have a pointer to them.
Tom