Re: 4.1 PATCH: Fix libjava bootstrap failure in split-for-gcj.sh

[Andrew Pinski <pinskia at physics dot uc dot edu>]

On Aug 10, 2005, at 1:51 PM, Rainer Orth wrote:

> Mainline bootstrap as of 20050805 failed in libjava on Solaris 10/x86 
> and
> Tru64 UNIX V5.1B due to the use of unportable shell constructs in
> classpath/lib/split-for-gcj.sh:
>
> /vol/gnu/src/gcc/gcc-dist/libjava/classpath/lib/split-for-gcj.sh: bad 
> substitution
>
> This file is unconditionally run by /bin/sh, but /bin/sh on those 
> systems
> doesn't support
>
>    real=${file%.1}
>
> Even after this is fixed, the use of ! in
>
> if ! cmp /dev/null /dev/null; then echo fail;
>
> yields
>
> /vol/gnu/src/gcc/gcc-dist/libjava/classpath/lib/split-for-gcj.sh: !: 
> not found
>
> The latter is documented in the Autoconf manual sub `Limitations of
> Builtins'.
>
> The following patch fixes both problems and allows the bootstrap to 
> finish
> without regressions.
>
> Ok for mainline?

Isn't better just to run split-for-gcj.sh with the CONFIG_SHELL or will 
not work
the above problems?  If it does with the recommended CONFIG_SHELL, then 
this is
PR 23238: <http://gcc.gnu.org/PR23238>.

-- Pinski