This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [patch] libffi: SH: fix on sh3
- From: Kaz Kojima <kkojima at rr dot iij4u dot or dot jp>
- To: sugioka at itonet dot co dot jp
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 22 Jul 2005 15:28:05 +0900 (JST)
- Subject: Re: [patch] libffi: SH: fix on sh3
- References: <4.2.0.58.J.20050722113210.02953f10@router.itonet.co.jp>
SUGIOKA Toshinobu <sugioka@itonet.co.jp> wrote:
> On sh3, struct argument may passed partially on register and the rest
> on stack. Mainline does not handle this case correctly.
> I think it's better to change stack layout in ffi_closure_SYSV so that
> arguments are stored in contiguous address.
>
> The result of make check on sh3-linux is
>
> === libffi Summary ===
>
> # of expected passes 228
> # of unsupported tests 2
This is fine, though I'm not qualified to approve it.
A minor nit, it looks the last line of the ChangeLog entry
has a cut&paste error. I suppose it would be
(ffi_prep_cif_machdep): Don't set too many cif->flags.
BTW, please don't forget -p option to diff next time :-)
Regards,
kaz