Re: Patch: FYI: Get xlib peers working again - OK for branch-4.0?

["Scott Gilbertson" <scottg at mantatest dot com>]

> Unfortunately I just broke them again with the big classpath merge.

OK, I'll get the latest sources and see what happens.

> You can turn
> on building them again pretty easily: remove the gnu/awt/xlib and
> gnu/gcj/xlib lines from libjava/standard.omit, run makemake.tcl
> (redirect stdout to sources.am), and run automake.

Thanks for the help, but I'm wondering why they had to be disabled that way.
I would have thought everything would work OK so long as you didn't have
"--enable-java-awt=xlib".  Is that no longer the case?

> Do the peers compile or work at all in 4.0?

Compiles OK, but nothing paints in a typical application.

----- Original Message ----- 
From: "Tom Tromey" <tromey@redhat.com>
To: "Scott Gilbertson" <scottg@mantatest.com>
Cc: <java-patches@gcc.gnu.org>
Sent: Monday, July 18, 2005 1:53 PM
Subject: Re: Patch: FYI: Get xlib peers working again - OK for branch-4.0?


> >>>>> "Scott" == Scott Gilbertson <scottg@mantatest.com> writes:
>
> Scott> I just checked in these changes to trunk.  The xlib peers had
> Scott> been busted for a long time, and these changes get them working
> Scott> at least as well as they did a year ago (using my large
> Scott> application for testing).
>
> Unfortunately I just broke them again with the big classpath merge.
>
> As I recall the problem is that ClasspathToolkit now declares some
> abstract methods that the xlib peers do not implement.  You can turn
> on building them again pretty easily: remove the gnu/awt/xlib and
> gnu/gcj/xlib lines from libjava/standard.omit, run makemake.tcl
> (redirect stdout to sources.am), and run automake.
>
> Scott> OK to commit the equivalent patch to branch-4.0?
>
> Do the peers compile or work at all in 4.0?
> Our rule thus far for 4.0.x has been that we won't break the C++
> ABI.  That is a pretty strict rule.
>
> Tom