This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: RFA: Fix PR libgcj/21906
- From: Andrew Haley <aph at redhat dot com>
- To: Tom Tromey <tromey at redhat dot com>
- Cc: Java Patch List <java-patches at gcc dot gnu dot org>, Gcc Patch List <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 15 Jun 2005 17:08:57 +0100
- Subject: Re: Patch: RFA: Fix PR libgcj/21906
- References: <m3fyvjaa2c.fsf@localhost.localdomain>
Tom Tromey writes:
> In PR 21906, the problem is that a method pointer is NULL. This
> causes a hang.
>
> This fix works by ensuring that we never see a NULL in a method table
> entry. Instead all abstract methods refer to _Jv_ThrowAbstractMethodError.
>
> Tested on x86 FC2 including jacks. Ok?
>
> Tom
>
> Index: gcc/java/ChangeLog
> from Tom Tromey <tromey@redhat.com>
>
> PR libgcj/21906:
> * class.c (make_method_value): Use soft_abstractmethod_node for
> abstract method.
> * java-tree.h (soft_abstractmethod_node): New define.
> (JTI_SOFT_ABSTRACTMETHOD_NODE): New enum constant.
> * decl.c (java_init_decl_processing): Initialize
> soft_abstractmethod_node.
Seems reasonable.
Andrew.