This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch FYI: obvious posix socket fix
- From: Anthony Green <green at redhat dot com>
- To: java-patches at gcc dot gnu dot org
- Date: Sun, 05 Jun 2005 23:18:29 -0700
- Subject: Patch FYI: obvious posix socket fix
I've checked the attached obvious fix into HEAD and the 4.0 branch.
We were missing a "break;" in one of our switch statements resulting in
bogus socket timeout values. Discovered while debugging Azureus.
AG
2005-06-05 Anthony Green <green@redhat.com>
* gnu/java/net/natPlainSocketImplPosix.cc (setOption): Fix case
fall-through bug.
Index: gnu/java/net/natPlainSocketImplPosix.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/net/natPlainSocketImplPosix.cc,v
retrieving revision 1.11.6.1
diff -u -p -r1.11.6.1 natPlainSocketImplPosix.cc
--- gnu/java/net/natPlainSocketImplPosix.cc 15 Mar 2005 16:43:41 -0000 1.11.6.1
+++ gnu/java/net/natPlainSocketImplPosix.cc 6 Jun 2005 06:07:11 -0000
@@ -646,6 +646,7 @@ gnu::java::net::PlainSocketImpl::setOpti
if (::setsockopt (native_fd, SOL_SOCKET, SO_REUSEADDR, (char *) &val,
val_len) != 0)
goto error;
+ return;
#else
throw new ::java::lang::InternalError (
JvNewStringUTF ("SO_REUSEADDR not supported"));