This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: MAXPATHLEN usage - PR21821
- From: Bryce McKinlay <mckinlay at redhat dot com>
- To: David Daney <ddaney at avtrex dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Wed, 01 Jun 2005 19:12:36 -0400
- Subject: Re: Patch: MAXPATHLEN usage - PR21821
- References: <429E3E31.4000503@redhat.com> <429E3F00.1070406@avtrex.com>
David Daney wrote:
Bryce McKinlay wrote:
+ ::java::lang::StringBuffer *msg = new
::java::lang::StringBuffer (path);
+ msg->append (JvNewStringUTF (" ("));
+ msg->append (JvNewStringUTF (strerror (errno)));
+ msg->append (JvNewStringUTF (")"));
+ throw new ::java::io::FileNotFoundException (msg->toString ());
Shouldn't we now be using StringBuilder instead of StringBuffer in
places like this?
Yeah, good point. It would be worth doing a pass over the entire library
and substituting StringBuffer->StringBuilder everywhere.
Bryce