This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFA] gnu.gcj.jdwp.transport: packet classes


On May 29, 2005, at 2:23 PM, Tom Tromey wrote:

Keith> + bytes[i++] = (byte) ((length >>> 24) & 0xff);

These don't need the '& 0xff' as the cast to byte does that
implicitly.  But if you want to keep this for extra clarity, I won't
complain.


And >>> fills with zero always which is unlike >> which fills
with the sign bit (>>> is like unsigned >> in C/C++).

Thanks,
Andrew Pinski

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]