Re: Recognize obsoleted options

[Aaron Luchko <aluchko at redhat dot com>]

On Thu, 2005-05-12 at 12:15 -0600, Tom Tromey wrote:
> >>>>> "Aaron" == Aaron Luchko <aluchko@redhat.com> writes:
> 
> Aaron> These three options, '-verify' '-noverify' and '-verifyremote' are all
> Aaron> obsolete as of JDK 1.2 and verify is on by default but they should still
> Aaron> be parsed for reasons of backwards compatibility.
> 
> Looks good, but I have a few nits.
> 
> Aaron> 2005-05-12  Aaron Luchko  <aluchko@redhat.com>
> Aaron>         * gij.cc (main): Recognize '-verify', '-noverify', and
> Aaron>         '-remoteverify'
> 
> The spelling of '-verifyremote' in the ChangeLog entry disagrees with
> the patch.
> 

oops, fixed in the ChangeLog entry

> Aaron> diff -r1.27 gij.cc
> Aaron> 298a299,306
> 
> Please send unidiffs.
> 
> FWIW, -noverify could actually do something.  Want to implement that?

The only real documentation of any of these I could find is an oreilly
book.  Although the sun vm accepts all these options I don't believe
they implement them since it's obsoleted, also looking at the size of
diffs of straces of runs with and without the option there wasn't much
of a difference with the -noverify.  
The only mention of any of these options on the sun site I could find is
this bug report which seems to suggest none of them are implemented
http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4337532

If it's easy enough it could do as an optimization, I took a glimpse at
links.cc and think it may be possible to do easily but I don't know the
code that well.

> Also, you have to update gcc/java/gcj.texi to account for the new
> options.

2005-05-12  Aaron Luchko <aluchko@redhat.com>

        * gcj.texi: Add '-verify', '-noverify', and '-verifyremote'.

Index: gcc/java/gcj.texi
===================================================================
RCS file: /cvs/gcc/gcc/gcc/java/gcj.texi,v
retrieving revision 1.85
diff -u -r1.85 gcj.texi
--- gcc/java/gcj.texi   12 May 2005 01:26:50 -0000      1.85
+++ gcc/java/gcj.texi   12 May 2005 21:38:27 -0000
@@ -1137,7 +1137,8 @@
 compatibility with existing application launch scripts:
 @code{-client}, @code{-server}, @code{-hotspot}, @code{-jrockit},
 @code{-agentlib}, @code{-agentpath}, @code{-debug}, @code{-d32},
-@code{-d64}, @code{-javaagent} and @code{-noclassgc}.
+@code{-d64}, @code{-javaagent}, @code{-noclassgc}, @code{-verify},
+@code{-noverify} and @code{-verifyremote}.

 @c man end



2005-05-12  Aaron Luchko  <aluchko@redhat.com>

        * gij.cc (main): Recognize '-verify', '-noverify', and
        '-verifyremote'

Index: libjava/gij.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gij.cc,v
retrieving revision 1.27
diff -u -r1.27 gij.cc
--- libjava/gij.cc      15 Apr 2005 02:40:02 -0000      1.27
+++ libjava/gij.cc      12 May 2005 21:39:09 -0000
@@ -296,6 +296,14 @@
         nonstandard_opts_help ();
       else if (! strncmp (arg, "-X", 2))
         add_option (vm_args, arg, NULL);
+      // As of version JDK 1.2 the following options are all obsolete
+      // but are required for backwards compatibility
+      else if (! strcmp (arg, "-verify"))
+        continue;
+      else if (! strcmp (arg, "-noverify"))
+        continue;
+      else if (! strcmp (arg, "-verifyremote"))
+        continue;
       else
        {
          fprintf (stderr, "gij: unrecognized option -- `%s'\n",
argv[i]);