This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: PR 21372 (FileChannel.tryLock())


>>>>> "Andrew" == Andrew Overholt <overholt@redhat.com> writes:

Andrew> Sorry for the spam, but here's an updated version of the toString
Andrew> re-implementation (what I intended to send the first time) that uses
Andrew> StringBuffer.

Actually, one little nit:

Andrew> +    StringBuffer buf = new StringBuffer(getClass().getName());
Andrew> +    buf.append("[" + position + ":" + size);

It is better to avoid '+' here if you really want to get the benefits
of StringBuffer.  I'll make that change.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]