This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] gjnih



On Apr 28, 2005, at 7:41 PM, Thomas Fitzsimmons wrote:


Hi,

This patch adds another front-end to gcjh, called gjnih. It is intended
to be a command-line compatible replacement for Sun's javah tool. It
generates JNI headers by default. "make check" in libjava shows no new
regressions. OK for mainline?

You should not encode the executable name in the output so: + return gjavah_main (argc, argv, 1, "gjnih");

Should be instead:
+  return gjavah_main (argc, argv, 1, argv[0]);


This is a GNU code style requirement by the way.


Thanks,
Andrew Pinski


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]