Re: [Patch] java.util.logging.LogManager

[Bryce McKinlay <mckinlay at redhat dot com>]

Michael Koch wrote:

> Hi list,
>
>
> I just commited the attached patch to merge it from GNU classpath to
> HEAD to. It mainly reformates the LogManager.java file and fixes an
> issue with logger keys.
>
>
> Michael
>
>
> 2005-04-22  Sven de Marothy  <sven@physto.se>
>
> 	* java/util/logging/LogManager.java: Reformatted.
> 	(readConfiguration): If a logger for a key is not found, create one.
>  

Sven,

Firstly, please don't ever put formatting and code changes in the same 
patch! This is bad because it makes it difficult to distinguish code 
changes from changes that are purely reformatting.

Secondly, some of the formatting changes you made go against out 
established style. We break lines at 80-columns unless there is no way 
to cleanly do so. Also, 2-char indenting should be used for all methods, 
including "static" blocks.

Bryce

> @@ -132,20 +129,19 @@
>    * behave differently from the reference implementation in
>    * this case.
>    */
> -  private final PropertyChangeSupport pcs
> -    = new PropertyChangeSupport(/* source bean */ LogManager.class);
> +  private final PropertyChangeSupport pcs = new PropertyChangeSupport( /* source bean */
> +  LogManager.class);
>