Re: [RFC PATCH] Don't use ELF weak for entities with vague linkagewhen COMDAT groups are available

[Julian Brown <julian at codesourcery dot com>]

Andrew Haley wrote:
> Andrew Haley writes:
>  > Julian Brown writes:
>  >  > 
>  >  > If people would try this patch and run the testsuite on their machines, 
>  >  > I'd be grateful. I'd appreciate it if you post information about 
>  >  > failures which show up for you, with version numbers of binutils bits, 
>  >  > so I can attempt to track down whatever broke before.
>  > 
>  > This patch breaks indirect dispatch with PIC.  With some files, I'm
>  > now getting errors of the form
>  > 
>  > jacorb.s:9882754: Error: can't resolve `.gnu.linkonce.t._ZN3org3omg21CosNotifyChannelAdmin22_ProxyPushSupplierStub15lifetime_filterEv' {.gnu.linkonce.t._ZN3org3omg21CosNotifyChannelAdmin22_ProxyPushSupplierStub15lifetime_filterEv section} - `.Ltext0' {.text section}
>
> Julian, would you like me to put the testcase somewhere?  Create a PR?
> We need this fixed for gcj development to proceed.

Yeah, a testcase might be a good idea (I'm not familiar enough with the 
Java frontend to be able to reproduce this easily myself, I don't 
think). Also, could you tell me the platform and binutils versions you 
are using, in case it's dependent on that?

It's probably best if I revert this part of the patch too, for now, so 
I'll do that.

Cheers,

Julian