Re: New stack trace code

[Andrew Haley <aph at redhat dot com>]

Bryce McKinlay writes:
 > Andrew Haley wrote:
 > 
 > >Bryce McKinlay writes:
 > >
 > > > Try -Dgnu.gcj.runtime.NameFinder.use_addr2line=false
 > > > 
 > > > addr2line is certainly too slow when an application calls it frequently, 
 > > > but I think maybe we should wait until we do some performance tests on 
 > > > the dwarf2 reader
 > >
 > >That depends on when we might get the dwarf2 reader.
 > >
 > > > before deciding whether it is neccessary for an option that
 > > > disables line numbers globally.
 > >
 > >Why?  We can always take it out again.  If it just so happens that the
 > >dwarf2 reader makes it unnecessary, then we will rejoice.
 > >
 > >At the present time logging is painful because of the calls to
 > >addr2line, and the ability to disable it is an enhancemant.
 > >
 > 
 > Yes, but we already have a system property to do this! Do we really need 
 > to add another one?

Sorry, I read your post and it looked like you awere arguing against
having the ability to disable addr2line!  OK, now I realize your point
was rather different.

 > > > Also, the overhead of getting line numbers for interpreted
 > > > frames is small, so I don't think it makes sense to disable for
 > > > that case as well.
 > >
 > >Sure, but if an application has no need for line numbers, then it
 > >makes no sense to get them, no matter how small the overhead.
 > 
 > I think line numbers are useful for any application. Unless your 
 > application has no bugs ...

Well, yes, but it depends on the cost.  When the dwarf reader goes in
we'll know for sure.

Andrew.