This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [RFC/RFT] Patch (java): Switch to new verifier


Ranjit Mathew wrote:
> OK for mainline?

I'll let Tom make this call: If he thinks we're ready to switch,
then great - let's do so.

> FWIW, the new verifier does seem a bit slower than the old one,

Some performance tuning might be worthwhile.  I see some obvious
micro-optimizations, but I suspect they won't make much difference.
Still, wouldn't urt:

get_short, get_short, get_int should have their get_byte calls inlines,
and the test for "premature end of bytecode" only done once.

Various places get_byte etc are called and the result ignored.
They could be replaced by skip_bytes (N).  E.g. in op_multianewarray
replace 'get_short(); get_byte();' by 'skip_bytes (3);'.
--
	--Per Bothner
per@bothner.com   http://per.bothner.com/


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]