This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Patch: PR 20029
On Mon, Feb 21, 2005 at 09:31:40PM -0500, Thomas Fitzsimmons wrote:
> On Mon, 2005-02-21 at 18:38 -0600, Michael Koch wrote:
>
> > A configure check is definitely needed. Even when the version of X is
> > recent enough its likely that the developement files needed for XTest
> > are not installed (at least on Debian where whole X stuff is separated
> > into much small packages).
>
> Here is a new patch that includes the same configure check as GNU
> Classpath. The check is only performed if --enable-java-awt=gtk is
> given. OK?
>
> Tom
>
> 2005-02-21 Thomas Fitzsimmons <fitzsim@redhat.com>
>
> PR libgcj/20029:
> * Makefile.am (lib_gnu_java_awt_peer_gtk_la_CFLAGS): Add X_CFLAGS.
> (lib_gnu_java_awt_peer_gtk_la_LDFLAGS): Add X_LIBS and -lXtst.
> * Makefile.in: Regenerate.
> * configure.ac: Check for libXtst.
> * configure: Regenerate.
I'm okay with this. GNU classpath uses nearly the same check.
> + # We require the XTest Extension to support java.awt.Robot.
> + AC_CHECK_LIB([Xtst], [XTestQueryExtension], [true],
> + [AC_MSG_ERROR([libXtst not found, required by java.awt.Robot])],
> + [${X_LIBS}])
One minor comment: The Xtst library is only needed for GdkRobot, not
Robot. Other peers might use other libraries to do this.
Michael