Re: [Patch] PR libgcj/19444 - java.net.URI fixes

[Michael Koch <konqueror at gmx dot de>]

Am Samstag, 15. Januar 2005 17:48 schrieb Mark Wielaard:
> On Sat, 2005-01-15 at 17:22 +0100, Michael Koch wrote:
> > +           if (portStr != null)
> > +             try
> > +               {
> > +                 port = Integer.parseInt(portStr);
> > +               }
> > +             catch (NumberFormatException e)
> > +               {
> > +                 URISyntaxException use = new
> > URISyntaxException(str, "doesn't match URI regular expression");
> > +                 use.initCause(e);
> > +                 throw e;
> > +               }
>
> Please wrap that long line.
> And you want to throw the URISyntaxException use, not just the
> NumberFormatException e.

Thanks, you are obviously right. This happens when you want to get a 
patch out fast.


Michael
-- 
Homepage: http://www.worldforge.org/