This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Patch: fix java.ext.dirs (not checked in)


I'm not checking this in as I don't believe it fixes a regression.

Mark pointed out on irc that you can't set java.ext.dirs from the
`gij' command line.  The property was being set too late.  This patch
fixes the bug.

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* java/lang/natRuntime.cc (insertSystemProperties): Set
	java.ext.dirs earlier.

Index: java/lang/natRuntime.cc
===================================================================
RCS file: /cvs/gcc/gcc/libjava/java/lang/natRuntime.cc,v
retrieving revision 1.43
diff -u -r1.43 natRuntime.cc
--- java/lang/natRuntime.cc 25 Nov 2004 03:47:04 -0000 1.43
+++ java/lang/natRuntime.cc 3 Dec 2004 18:10:41 -0000
@@ -537,8 +537,13 @@
       SET ("user.region", "US");
     }  
 
+  // The java extensions directory.
+  SET ("java.ext.dirs", JAVA_EXT_DIRS);
+
   // Set some properties according to whatever was compiled in with
-  // `-D'.
+  // `-D'.  Important: after this point, the only properties that
+  // should be set are those which either the user cannot meaningfully
+  // override, or which augment whatever value the user has provided.
   for (int i = 0; _Jv_Compiler_Properties[i]; ++i)
     {
       const char *s, *p;
@@ -595,9 +600,6 @@
   // The name used to invoke this process (argv[0] in C).
   SET ("gnu.gcj.progname", _Jv_GetSafeArg (0));
 
-  // The java extensions directory.
-  SET ("java.ext.dirs", JAVA_EXT_DIRS);
-
   // Allow platform specific settings and overrides.
   _Jv_platform_initProperties (newprops);
 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]