This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] merge/import X509 certificate code from Classpath


>>>>> "Bryce" == Bryce McKinlay <mckinlay@redhat.com> writes:

Bryce> This looks good, thanks. I'm not entirely sure that the use of
Bryce> static references to force the providers to be linked in when
Bryce> compiling statically is a good idea, however, we've done this
Bryce> elsewhere and you've flagged it with a comment so I think its
Bryce> ok for now. I don't think they will hurt if we, eventually,
Bryce> come up with a better static linking solution.

Aside from static linking, using "class.getName()" in provider
definitions absolutely guarantees that algorithm names point to the
correct class. I don't know about you, but I know that I can't spell
correctly.

-- 
Casey Marshall || csm@gnu.org


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]