This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Patch: FYI: add clarifying comment
- From: Tom Tromey <tromey at redhat dot com>
- To: Java Patch List <java-patches at gcc dot gnu dot org>
- Date: 09 Nov 2004 15:40:10 -0700
- Subject: Patch: FYI: add clarifying comment
- Reply-to: tromey at redhat dot com
I'm checking this in.
Our typedefs in jni.h are not completely portable, they will be wrong
on weird architectures. I'm not super interested in fixing this
unless a port to one of these is actually done, so for now I'm just
adding this clarifying FIXME comment.
Tom
Index: ChangeLog
from Tom Tromey <tromey@redhat.com>
* include/jni.h: Added FIXME.
Index: include/jni.h
===================================================================
RCS file: /cvs/gcc/gcc/libjava/include/jni.h,v
retrieving revision 1.28
diff -u -r1.28 jni.h
--- include/jni.h 3 Nov 2004 22:53:20 -0000 1.28
+++ include/jni.h 9 Nov 2004 22:40:20 -0000
@@ -44,7 +44,9 @@
# ifdef __GNUC__
/* If we're using gcc, we can use a platform-independent scheme to get
- the right integer types. */
+ the right integer types. FIXME: this is not always correct, for
+ instance on the c4x it will be wrong -- it depends on whether
+ QImode is 8 bits. */
typedef int jbyte __attribute__((__mode__(__QI__)));
typedef int jshort __attribute__((__mode__(__HI__)));
typedef int jint __attribute__((__mode__(__SI__)));