Re: [gui][PATCH] Add missing Font fields

[Mark Wielaard <mark at klomp dot org>]

On Wed, 2004-11-03 at 16:04, Bryce McKinlay wrote:
> Thomas Fitzsimmons wrote:
> >On Tue, 2004-11-02 at 17:22, Tom Tromey wrote:
> >
> >>Tom> 2004-11-02  Thomas Fitzsimmons  <fitzsim@redhat.com>
> >>Tom> 	* java/awt/Font.java (name): New field.
> >>Tom> 	(size): Likewise.
> >>Tom> 	(style): Likewise.
> >>
> >>This seems a little weird to me, since the new fields aren't actually
> >>used anywhere.  Are they supposed to mean something to subclasses?  I
> >>understand wanting to have them to claim API compatibility
> >
> >Yeah, this is the reason I added them.
> >  
> To me it looks like a bug in the spec - a historical accident. The 
> fields should never really have been visible to subclasses. 
> Nevertheless, in order to claim compatibility we might as well make sure 
> we have them.

And Font is Serializable which means we should at least write them out
on the ObjectOutputStream. By adding them as real fields that should
happen automatically.

Cheers,

Mark

Attachment: signature.asc
Description: This is a digitally signed message part