This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH] Fix PR java/17265

From: Bryce McKinlay <mckinlay at redhat dot com>
To: Eric Botcazou <ebotcazou at libertysurf dot fr>
Cc: gcc-patches at gcc dot gnu dot org, java-patches at gcc dot gnu dot org
Date: Fri, 22 Oct 2004 14:34:51 -0400
Subject: Re: [PATCH] Fix PR java/17265
References: <200410221234.26719.ebotcazou@libertysurf.fr>

Eric Botcazou wrote:

Hi,

This patch reverts

2004-08-18 Bryce McKinlay <mckinlay@redhat.com>
       * class.c (make_local_function_alias): New function. Create local
       alias for public method DECL.
       (make_method_value): Use make_local_function_alias.
which breaks the GCJ compiler with non-GNU assemblers. The problem is that it instructs the compiler to create local aliases of external functions.

Eric,

Could you try this version of the patch and see if it fixes 17265 for you? This one will not try to emit an alias for an external function (which I agree is useless). Making an alias for a local function however is not useless - we need this for accurate stack traces and security checks, so I'd like to get this patch back in.

Bryce

Follow-Ups:
- Re: [PATCH] Fix PR java/17265
  - From: Bryce McKinlay
- Re: [PATCH] Fix PR java/17265
  - From: Eric Botcazou

References:
- [PATCH] Fix PR java/17265
  - From: Eric Botcazou

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]