This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [PATCH] Fix PR java/17265
Andrew Haley wrote:
Eric Botcazou writes:
> Hi,
>
> This patch reverts
>
> 2004-08-18 Bryce McKinlay <mckinlay@redhat.com>
>
> * class.c (make_local_function_alias): New function. Create local
> alias for public method DECL.
> (make_method_value): Use make_local_function_alias.
>
> which breaks the GCJ compiler with non-GNU assemblers. The problem is that it
> instructs the compiler to create local aliases of external functions.
Right; that's what we need.
> Quoting comment #6 from RTH: "Note that while this construct is *accepted* by
> gas, it won't do what you might think it would. It does nothing useful.
> I've wished in the past that gas would diagnose this problem..."
AFAIK, RTH wasn't referring to make_local_function_alias() in general
here, which certainly does do something useful, namely giving us real
pointers to functions in gcj's class metadata rather than pointers to
PLT entries, which causes problems for our stack trace code.
Is this problem occuring because aliases are being created to external
functions? In that case we should just fix make_local_function_alias()
to not make an alias for an external function.
Bryce