This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: C++ PATCH: 14035
- From: Tom Tromey <tromey at redhat dot com>
- To: Andreas Schwab <schwab at suse dot de>
- Cc: mark at codesourcery dot com, java-patches at gcc dot gnu dot org, gcc-patches at gcc dot gnu dot org
- Date: 20 Oct 2004 11:08:05 -0600
- Subject: Re: C++ PATCH: 14035
- References: <200410192329.i9JNTEcX022990@sirius.codesourcery.com><jemzyho8k2.fsf@sykes.suse.de>
- Reply-to: tromey at redhat dot com
>>>>> "Andreas" == Andreas Schwab <schwab@suse.de> writes:
Andreas> The casts to int should probably be changed to casts to
Andreas> uaddr. I'm testing this patch now:
This is ok, just one minor nit.
Andreas> + _Jv_Utf8Const *name = klass->constants.data[(uaddr)superclass].utf8;
Space after the cast please.
Andreas> + superclass = klass->constants.data[(uaddr)superclass].clazz;
Likewise.
Tom