Re: [gui] Implement RescaleOp

[Andrew Haley <aph at redhat dot com>]

Mark Wielaard writes:
 > 
 > On Thu, 2004-09-30 at 11:25, Andrew Haley wrote:
 > > Michael Koch writes:
 > >  > On Wednesday 29 September 2004 04:09, Jerry Quinn wrote:
 > >  > > Fixed.  I was using a combination of eclipse and emacs and the
 > >  > > braces on line slipped through.  I take the blame for the
 > >  > > one-liners :-)
 > >  > 
 > >  > You don't posted your commited fixes here, or did I missed something ?
 > >  > Please post every little patch you commit on this list. This makes 
 > >  > merging to GNU classpath much easier for us.
 > > 
 > > Isn't there something like a cvs-commit mailing list that would ba far
 > > more suitable for such purposes?
 > 
 > There is a mailinglist for all CVS commits of GCC, gcc-cvs.
 > That is much more than necessary for the GNU Classpath/libgcj merging
 > work. It does not give the actual patches (only points to some URLs
 > which are not very convenient when not online).

Good point.  That's unfortunate.

 > And most importantly the patches mailinglist is to announce the
 > intention of what will be changed and the cvs commit mailinglist is
 > what has actually been checked in.  These are two different things,
 > you use one to check that what was intended was actually what was
 > changed.

Exactly so: this is a strong reason not to use the patches mailing
list to do merges, but the CVS checkins themselves.

 > As long as we are not completely merged and gcj doesn't just use GNU
 > Classpath glibj out of the box we really need people to post the actual
 > patches so they can be checked and merged with upstream easily.
 > 
 > That, or we will have to ask libgcj hackers to explicitly propose and
 > post patches on classpath-patches if they want them to be integrated.

The patches mailing list is for people to read.  We try to make sure
that patches are in a form that can be merged, but its primary purpose
is for patch discussion.  

As far as I am awre, it has always been customary to accept patches
with a caveat of "please fix the indentation before check-in" and such
patches are not re-posted.  You are proposing a change of policy.

Andrew.