[OT] files-per-line (Was: Re: Patch: configure.in cleanup)

[Dalibor Topic <robilad at kaffe dot org>]

Michael Koch wrote:
> Am Freitag, 20. August 2004 02:59 schrieb Bryce McKinlay:
>
> > Michael Koch wrote:
> >
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Hi list,
> > >
> > >
> > > I wrote the attached patch to cleanup configure.in. Bootstrapped
> > > on i686-pc-linux-gnu.
> > >
> > > Ok to commit to trunk ?
> >
> > OK, except for...
> >
> >
> > > -AC_OUTPUT(Makefile libgcj.pc libgcj.spec libgcj-test.spec
> > > gnu/classpath/Configuration.java gcj/Makefile include/Makefile
> > > testsuite/Makefile, +AC_CONFIG_FILES(
> > > +Makefile
> > > +gcj/Makefile
> > > +include/Makefile
> > > +testsuite/Makefile
> > > +libgcj.pc
> > > +libgcj.spec
> > > +libgcj-test.spec
> > > +gnu/classpath/Configuration.java
> > > +)
> >
> > Is the 1-per-line approach really better? It might make for cleaner
> > diffs, but I think it'd be easier to read if we had a few files per
> > line, although wrapped at 80 chars... what do you think?
>
>
> Personally I prefer it this way because it makes diffs cleaner when 
> someone adds/removes a file and it doesn't size up configure.in/ac.

Me too.

Putting it all on a single line and then wrapping means that people may 
waste time shuffling white space around when they add a file to keep 
everything aligned at 80 spaces (if they know the 80 spaces rule at all 
;) instead of doing something more productive for gcj with their time ;)

Beside, having all files on a separate line means that you get 
meaningful, readable, *small* diffs, when things change. And things 
change a lot, right? :)

cheers,
dalibor topic