This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: libffi: improvements for MIPS o32.
- From: Casey Marshall <csm at gnu dot org>
- To: David Daney <ddaney at avtrex dot com>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 23 Jul 2004 11:47:21 -0700
- Subject: Re: PATCH: libffi: improvements for MIPS o32.
- References: <87hdssn6f3.fsf@gnu.org> <41015429.2010403@avtrex.com>
>>>>> "David" == David Daney <ddaney@avtrex.com> writes:
David> Casey Marshall wrote:
>> # of expected passes 2711
>> # of unexpected failures 24
>> # of expected failures 14
>> # of untested testcases 34
>>
>> Comments greatly appreciated.
>>
>> 2004-06-30 Casey Marshall <csm@gnu.org>
>>
>> * src/mips/ffi.c (ffi_pref_cif_machdep): set `cif->flags' to
>> contain `FFI_TYPE_UINT64' as return type for any 64-bit
>> integer (O32 ABI only).
>> (ffi_prep_closure): new function.
>> (ffi_closure_mips_inner_O32): new function.
>> * src/mips/ffitarget.h: Define `FFI_CLOSURES' and
>> `FFI_TRAMPOLINE_SIZE' appropriately if the ABI is o32.
>> * src/mips/o32.S (ffi_call_O32): add labels for .eh_frame. Return
>> 64 bit integers correctly.
>> (ffi_closure_O32): new function.
>> Added DWARF-2 unwind info for both functions.
David> My comments:
David> Do you have CVS write access? I cannot approve, but after
David> approval I could do the check-in if you don't have write
David> access.
No, I don't have write access.
David> Were there any testsuite regressions?
I wasn't able to run the libffi testsuite (it doesn't seem to be
friendly to a remote testing setup) but I did run the code against the
old-style `ffitest.c' program, and all of those pass.
David> Can you run the patch against the CVS HEAD?
I think the patch I posted was against HEAD, at least HEAD at the
time. Have there been any changes to libffi that might conflict?
David> I am getting ready to test the patch here, and if it works for
David> me would like to see it in CVS.
Were there any issues wrt soft float? From the discussion, it sounded
like the MIPS FFI code needs to be fitted with additional ABIs for
software float.
Also, I'm curious about platforms (like the PlayStation, I guess) that
support float but not doubles. There were FFI patches on the Kaffe
mailing list for this.
--
Casey Marshall || csm@gnu.org