This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH: libffi: improvements for MIPS o32.
- From: David Daney <ddaney at avtrex dot com>
- To: Casey Marshall <csm at gnu dot org>
- Cc: java-patches at gcc dot gnu dot org
- Date: Fri, 23 Jul 2004 11:08:41 -0700
- Subject: Re: PATCH: libffi: improvements for MIPS o32.
- References: <87hdssn6f3.fsf@gnu.org>
Casey Marshall wrote:
.
.
.
> # of expected passes 2711
> # of unexpected failures 24
> # of expected failures 14
> # of untested testcases 34
>
> Comments greatly appreciated.
>
>
> 2004-06-30 Casey Marshall <csm@gnu.org>
>
> * src/mips/ffi.c (ffi_pref_cif_machdep): set `cif->flags' to
> contain `FFI_TYPE_UINT64' as return type for any 64-bit
> integer (O32 ABI only).
> (ffi_prep_closure): new function.
> (ffi_closure_mips_inner_O32): new function.
> * src/mips/ffitarget.h: Define `FFI_CLOSURES' and
> `FFI_TRAMPOLINE_SIZE' appropriately if the ABI is o32.
> * src/mips/o32.S (ffi_call_O32): add labels for .eh_frame. Return
> 64 bit integers correctly.
> (ffi_closure_O32): new function.
> Added DWARF-2 unwind info for both functions.
My comments:
Do you have CVS write access? I cannot approve, but after approval I
could do the check-in if you don't have write access.
Were there any testsuite regressions?
Can you run the patch against the CVS HEAD?
I am getting ready to test the patch here, and if it works for me would
like to see it in CVS.
David Daney.