This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: Java: Remove set_nested_class_simple_name_value()
Andrew Haley wrote:
Bryce McKinlay writes:
>
> 2004-06-23 Bryce McKinlay <mckinlay@redhat.com>
>
> * parse.y (set_nested_class_simple_name_value): Removed.
> (java_complete_expand_class): Remove calls to
> set_nested_class_simple_name_value.
>
OK. I'm a little nervous about removing stuff like this -- there
presumably was a reason why it was necessary. However, unless we cut
things out we'll never get rid of the cruft, so go ahead.
Yeah, from what I can tell, this code was added very early on when inner
classes were first implemented, and presumably was a naive/incomplete
attempt at inner class name resolution. Now days all the
resolve_inner_class stuff doesn't appear to use it at all, and in fact
causes problems in the corner cases.
Also, we should probably be trying to clean up this kind of
identifier-node abuse anyway, because it won't be valid when we move to
statically typed trees.
Regards
Bryce