This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch: FYI: PR 16134

From: Bryce McKinlay <mckinlay at redhat dot com>
To: tromey at redhat dot com
Cc: java-patches at gcc dot gnu dot org
Date: Tue, 22 Jun 2004 15:09:13 -0400
Subject: Re: Patch: FYI: PR 16134
References: <40D86A76.2000900@redhat.com> <87brjbtq9n.fsf@fleche.redhat.com>

Tom Tromey wrote:

The original intent of this code was that the original (non-canonical)
name be passed to the iconv converter.  The idea is that our
canonicalization might result in a name not known by the underlying
iconv implementation.
This patch changes that. And actually I don't know that this has ever mattered. But it would be simple to restore this behavior by keeping the non-canonical name and passing it to the iconv converter constructor.

Hmm, the catch here is that we could now not cache iconv() encoders, if the name gets canonicalized, because the name in the cache for Iconv encoders won't match the canonicalized name.

Bryce

Follow-Ups:
- Re: Patch: FYI: PR 16134
  - From: Tom Tromey

References:
- Patch: FYI: PR 16134
  - From: Bryce McKinlay
- Re: Patch: FYI: PR 16134
  - From: Tom Tromey

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]