This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Urgent: Fix Bootstrap - Missing Imports


On Fri, 18 Jun 2004 02:54:29 -0400, graydon hoare <graydon@pobox.com> wrote:
> 
> Ranjit Mathew wrote:
> > Hi,
> >
> >     Can someone please apply this patch to fix a bootstrap
> > error in libjava due to missing import declarations?
> >
> > Thanks in advance,
> > Ranjit.
> >
> > Index: ChangeLog
> > from  Ranjit Mathew  <rmathew@hotmail.com>
> >
> >         * javax/swing/text/AbstractDocument.java: Adding missing import
> >         for javax.swing.event.EventListenerList.
> >         * javax/swing/text/DefaultCaret.java: Likewise.
> >
> 
> thanks, committed. it appears that my autotesting script had a bug, of
> course, and picked up a different directory (holding older gcj sources)
> in order to test. so all my tests were identical and pointless. yay.

Thanks for committing this so quickly.

However, you didn't update the ChangeLog.

Talking of ChangeLog, when you do your regular merges,
should you blindly update all the new ChangeLog entries 
to the current date (since that's when they really got applied
to mainline) or should you do a "merge sort" of ChangeLog 
entries?

The current situation is a bit weird since the reverse
chronological order property of the ChangeLog is
violated on such a merge - for example, Anthony's
change to VMClassLoader.java from 2004-06-17 now
appears *after* Tom Fitzsimmons's change of 2004-05-26.

I do not wish to increase your work unnecessarily, but
if there's a simple way of achieving this, it would be really
nice.

Ranjit.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]