This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: [patch] Fix java.util.zip.ZipEntry.setTime
- From: Tom Tromey <tromey at redhat dot com>
- To: Jerry Quinn <jlquinn at optonline dot net>
- Cc: java-patches at gcc dot gnu dot org
- Date: 14 Jun 2004 17:12:24 -0600
- Subject: Re: [patch] Fix java.util.zip.ZipEntry.setTime
- References: <E1BWiq3-00053T-00@localhost>
- Reply-to: tromey at redhat dot com
>>>>> "Jerry" == Jerry Quinn <jlquinn@optonline.net> writes:
Jerry> Currently, setTime mangles the time by scaling, constructing dostime,
Jerry> then unscaling dostime. The scaling is unnecessary.
Could you expand on that a bit?
My understanding is that DOS stores time in seconds, whereas Date
wants milliseconds. Hence the scaling and unscaling.
Jerry> - dostime = (int) (dostime / 1000L);
It seems like this line ought to be within the `synchronized'
statement.
Tom