This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Return of SimpleTimeZone fix


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am Dienstag, 8. Juni 2004 08:03 schrieb Jerry Quinn:
> Michael Koch writes:
>  > -----BEGIN PGP SIGNED MESSAGE-----
>  > Hash: SHA1
>  >
>  > Am Montag, 7. Juni 2004 14:57 schrieb Jerry Quinn:
>  > > Michael Koch writes:
>  > >  > Have you checked out a special version of the file ?
>  > >  > Perhaps cvs thinks you don't want to update it to a newer
>  > >  > version ...
>  > >
>  > > Moving my copy aside and cvs update -A still gives me the same
>  > > diffs.
>  > >
>  > >  > > I could post the whole file if you want.
>  > >  >
>  > >  > Please do so.
>  >
>  > I looked into it. You are right it gives one new FAIL for
>  > java.util.GregorianCalendar BUT you missed that around 200 tests
>  > for java.util.GregorianCalendar where not done because of the
>  > one FAIL.
>  >
>  > I think think its needed to fix both issues at once. Can you
>  > look into GregorianCalendar before this patch gets commited ?
>
> The following patch fixes the failures in
> gnu.testlet.java.util.GregorianCalendar.first.  Basically, the
> formulae are wrong, and the SimpleTimeZone fixes now reject the
> bogus inputs.  I don't have the presence of mind right now to work
> out better formulae or code, and this patch is no worse than what
> was there.
>
> Jerry
>
> 2004-06-08  Jerry Quinn  <jlquinn@optonline.net>
>
> 	* java/util/GregorianCalendar.java (computeTime):  Skip buggy
>         formulae when we already know the answer.


Looks good now, Thanks.


Michael
- -- 
Homepage: http://www.worldforge.org/
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.2.4 (GNU/Linux)

iD8DBQFAyK20WSOgCCdjSDsRApxkAKCebkOBsRsIWeeaiRtB8tgK05wh6wCffbOo
QMFGZWNKMVbl2S7RMeunTAk=
=fC94
-----END PGP SIGNATURE-----


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]