This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: Java: Improve character encoding error messages


On Sat, 22 May 2004, Tom Tromey wrote:

> Per> One nit - we're moving away from using "accept grave" as "left single
> Per> quote" - use '%s' instead.
> 
> How about we get rid of them all at once?  I don't think there is any
> use of "`" aside from these messages.  I ran s/`/'/ over
> gcc/java/*.[chy], and the result still compiles aand a spot check says
> it is sane...  if folks are amenable to this, I will read the whole
> patch for errors before submitting it for real.

The general proposal for handling quoting I gave at
<http://gcc.gnu.org/ml/gcc-bugs/2004-03/msg00302.html> had approval from
Gaby but this hasn't yet been implemented and would only apply to the code
using the diagnostic.c formatters - not other programs (though it might be
possible for them to use diagnostic.c as well) or runtime libraries.
Churning messages twice (getting rid of ` then later moving to a new
scheme) is bad for translators (if one were done before 3.5/4.0 branches,
and one after) but I don't expect people wanting to improve messages to
implement these new formats first and won't object to people improving and
changing messages (including quoting changes) as they see fit within the
existing diagnostic framework that doesn't yet include %` %' %q.  (I would
encourage that changes cover comments, and the whole of the GCC source
tree except for code imported from elsewhere (taking care over shell
scripts etc. legitimately using `), and that codingconventions.html make
clear that ` is a grave accent except where it stands for a left quote (as
in TeX and Texinfo), linking to
<http://www.cl.cam.ac.uk/~mgk25/ucs/quotes.html>.)

-- 
Joseph S. Myers
jsm@polyomino.org.uk


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]