Re: [gui][PATCH] include extra libraries in libgcj.spec.in

[Ranjit Mathew <rmathew at gmail dot com>]

Michael Koch wrote:
> Am Freitag, 14. Mai 2004 06:42 schrieb Ranjit Mathew:
> 
>>Thomas Fitzsimmons wrote:
>>[...]
>>
>>
>>>-*lib: -lgcj -lm @LIBICONV@ @GCSPEC@ @THREADSPEC@ @ZLIBSPEC@
>>>@SYSTEMSPEC@ %(libgcc) %(liborig) +*lib: -l-java-awt
>>>-l-java-applet -l-java-beans -l-javax-accessibility
>>>-l-javax-swing -lgcj -lm @LIBICONV@ @GCSPEC@ @THREADSPEC@
>>>@ZLIBSPEC@ @SYSTEMSPEC@ %(libgcc) %(liborig)
>>
>>Shouldn't this be conditional on whether AWT is
>>enabled?
>>
>>For example, we seem to support "--enable-java-awt=no"
>>in the libjava configury, though I don't know if anyone
>>builds it like that or if it is still valid.
> 
> 
> As this is only for "java-gui-branch" I think nobody cares about this.

Perhaps not for the moment, but stuff from the
java-gui-branch will be integrated into mainline soon,
so this *will* become an issue in the near future.

My understanding is that the splitting-libgcj-into-smaller-libs
thingy is only waiting for the BC-ABI to be integrated
into mainline.

Another thing about this patch is that it also unconditionally
creates dependencies on the AWT libraries even when AWT
is enabled in the build but isn't actually being used anywhere.

For example, this would not let one easily create RPMs
like:

  gcc-java-core-3.5.0.rpm
  gcc-java-awt-3.5.0.rpm

So we did a good thing by splitting libgcj into smaller
libs, but we would be undoing it by linking every application
with all libgcj libs.

My 2p.

Ranjit.

-- 
Ranjit Mathew          Email: rmathew AT gmail DOT com

Bangalore, INDIA.      Web: http://ranjitmathew.tripod.com/