This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
[gui][PATCH] Add FIXME comment to window peer
- From: Thomas Fitzsimmons <fitzsim at redhat dot com>
- To: java-patches at gcc dot gnu dot org
- Date: Fri, 23 Apr 2004 17:31:46 -0400
- Subject: [gui][PATCH] Add FIXME comment to window peer
Hi,
I committed this to java-gui-branch.
Tom
2004-04-23 Thomas Fitzsimmons <fitzsim@redhat.com>
* gnu_java_awt_peer_gtk_GtkWindowPeer.c: Add FIXME comment.
Index: jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c
===================================================================
RCS file: /cvs/gcc/gcc/libjava/jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c,v
retrieving revision 1.24.2.1
diff -u -r1.24.2.1 gnu_java_awt_peer_gtk_GtkWindowPeer.c
--- jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c 11 Mar 2004 23:41:35 -0000 1.24.2.1
+++ jni/gtk-peer/gnu_java_awt_peer_gtk_GtkWindowPeer.c 23 Apr 2004 21:28:54 -0000
@@ -46,6 +46,11 @@
static int filter_added = 0;
+// FIXME: this function is needed to work around double-activation
+// that occurs with metacity and GTK. See
+// http://bugzilla.gnome.org/show_bug.cgi?id=140977 for details. Owen
+// says filtering protocol messages will break future versions of GTK.
+// Once the bug is fixed, we'll remove this logic.
static GdkFilterReturn window_wm_protocols_filter (GdkXEvent *xev,
GdkEvent *event,
gpointer data);