Patch: gnu.java.nio.channels.FileChannelImpl

[Michael Koch <konqueror at gmx dot de>]

Hi list,


I just commited the attached patch to remove unused stuff and to make 
the implementation more simple.


Michael


2004-04-23  Michael Koch  <konqueror@gmx.de>

	* gnu/java/nio/channels/FileChannelImpl.java
	(SET, CUR): Unused, removed.
	(read): Implement here directly.
	(implRead): Removed.
	(write): Implement here directly.
	(implWrite): Removed.

Index: gnu/java/nio/channels/FileChannelImpl.java
===================================================================
RCS file: /cvs/gcc/gcc/libjava/gnu/java/nio/channels/FileChannelImpl.java,v
retrieving revision 1.2
diff -u -r1.2 FileChannelImpl.java
--- gnu/java/nio/channels/FileChannelImpl.java	20 Apr 2004 10:43:48 -0000	1.2
+++ gnu/java/nio/channels/FileChannelImpl.java	23 Apr 2004 06:55:18 -0000
@@ -60,13 +60,8 @@
  * Instances of this class are created by invoking getChannel
  * Upon a Input/Output/RandomAccessFile object.
  */
-
 public final class FileChannelImpl extends FileChannel
 {
-  // These are WHENCE values for seek.
-  static final int SET = 0;
-  static final int CUR = 1;
-
   // These are mode values for open().
   public static final int READ   = 1;
   public static final int WRITE  = 2;
@@ -139,7 +134,15 @@
 
   public int read (ByteBuffer dst) throws IOException
   {
-    return implRead (dst);
+    int result;
+    byte[] buffer = new byte [dst.remaining ()];
+    
+    result = read (buffer, 0, buffer.length);
+
+    if (result > 0)
+      dst.put (buffer, 0, result);
+
+    return result;
   }
 
   public int read (ByteBuffer dst, long position)
@@ -149,25 +152,12 @@
       throw new IllegalArgumentException ();
     long oldPosition = implPosition ();
     position (position);
-    int result = implRead (dst);
+    int result = read(dst);
     position (oldPosition);
     
     return result;
   }
 
-  private int implRead (ByteBuffer dst) throws IOException
-  {
-    int result;
-    byte[] buffer = new byte [dst.remaining ()];
-    
-    result = read (buffer, 0, buffer.length);
-
-    if (result > 0)
-      dst.put (buffer, 0, result);
-
-    return result;
-  }
-  
   public native int read ()
     throws IOException;
 
@@ -189,7 +179,20 @@
 
   public int write (ByteBuffer src) throws IOException
   {
-    return implWrite (src);
+    int len = src.remaining ();
+    if (src.hasArray())
+      {
+	byte[] buffer = src.array();
+	write(buffer, src.arrayOffset() + src.position(), len);
+      }
+    else
+      {
+	// Use a more efficient native method! FIXME!
+	byte[] buffer = new byte [len];
+    	src.get (buffer, 0, len);
+	write (buffer, 0, len);
+      }
+    return len;
   }
     
   public int write (ByteBuffer src, long position)
@@ -209,30 +212,12 @@
 
     oldPosition = implPosition ();
     seek (position);
-    result = implWrite (src);
+    result = write(src);
     seek (oldPosition);
     
     return result;
   }
 
-  private int implWrite (ByteBuffer src) throws IOException
-  {
-    int len = src.remaining ();
-    if (src.hasArray())
-      {
-	byte[] buffer = src.array();
-	write(buffer, src.arrayOffset() + src.position(), len);
-      }
-    else
-      {
-	// Use a more efficient native method! FIXME!
-	byte[] buffer = new byte [len];
-    	src.get (buffer, 0, len);
-	write (buffer, 0, len);
-      }
-    return len;
-  }
-  
   public native void write (byte[] buffer, int offset, int length)
     throws IOException;