This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: Patch: tcp sockets: removing code duplication

Michael Koch writes:
 > Am Montag, 19. April 2004 17:22 schrieb Andrew Haley:
 > >  > -
 > >  > -  return b & 0xFF;
 > >  >  }
 > >
 > > We should not remove this "& 0xFF".
 > >
 > > This patch renders DataInputStream totally broken, because negative
 > > values signal EOF.
 > 
 > 
 > Does the attached patch fixes this for you ? Okay for trunk ?
 > 
 > 2004-04-21  Michael Koch  <konqueror@gmx.de>
 > 
 > 	* gnu/java/net/natPlainSocketImplPosix.cc
 > 	(SocketInputStream::read): Make sure returned data is a byte value.

OK.

Andrew.
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]