This is the mail archive of the
java-patches@gcc.gnu.org
mailing list for the Java project.
Re: PATCH to optimize two Channels methods
- From: Richard Earnshaw <Richard dot Earnshaw at arm dot com>
- To: Per Bothner <per at bothner dot com>
- Cc: Michael Koch <konqueror at gmx dot de>, java-patches at gcc dot gnu dot org
- Date: Fri, 19 Mar 2004 13:17:26 +0000
- Subject: Re: PATCH to optimize two Channels methods
- References: <200403131412.i2DEC7mm028662@pc960.cambridge.arm.com>
On Sat, 2004-03-13 at 14:12, Richard Earnshaw wrote:
> > I didn't realize that configure overrides $PLATFORM with the more
> > specific $FILE for natFile.cc and in the old version
> > java/io/natFileDescriptor.cc. Thus you probably need to edit
> > configure.in
> > -AC_LINK_FILES(gnu/java/nio/channels/natFileChannel${PLATFORM}.cc,
> > gnu/java/nio/channels/natFileChannelImpl.cc)
> > +AC_LINK_FILES(gnu/java/nio/channels/natFileChannel${FILE-${PLATFORM}}.cc,
> > gnu/java/nio/channels/natFileChannelImpl.cc)
> >
> > and configure:
> > -ac_sources="include/$PLATFORMH java/io/natFile${FILE-${PLATFORM}}.cc
> > java/lang/${PLATFORM}Process.java java/lang/nat${PLATFORM}Process.cc
> > java/net/natInetAddress${PLATFORMNET}.cc
> > java/net/natNetworkInterface${PLATFORMNET}.cc
> > gnu/java/net/natPlainSocketImpl${PLATFORMNET}.cc
> > gnu/java/net/natPlainDatagramSocketImpl${PLATFORMNET}.cc
> > gnu/java/nio/natPipeImpl${PLATFORM}.cc
> > gnu/java/nio/natSelectorImpl${PLATFORM}.cc
> > gnu/java/nio/channels/natFileChannel${PLATFORM}.cc include/$GCHDR
> > include/$THREADH sysdep/$sysdeps_dir/locks.h $SIGNAL_HANDLER
> > $SIGNAL_HANDLER_AUX"
> > +ac_sources="include/$PLATFORMH java/io/natFile${FILE-${PLATFORM}}.cc
> > java/lang/${PLATFORM}Process.java java/lang/nat${PLATFORM}Process.cc
> > java/net/natInetAddress${PLATFORMNET}.cc
> > java/net/natNetworkInterface${PLATFORMNET}.cc
> > gnu/java/net/natPlainSocketImpl${PLATFORMNET}.cc
> > gnu/java/net/natPlainDatagramSocketImpl${PLATFORMNET}.cc
> > gnu/java/nio/natPipeImpl${PLATFORM}.cc
> > gnu/java/nio/natSelectorImpl${PLATFORM}.cc
> > gnu/java/nio/channels/natFileChannelnatFile${FILE-${PLATFORM}}.cc
> > include/$GCHDR include/$THREADH sysdep/$sysdeps_dir/locks.h
> > $SIGNAL_HANDLER $SIGNAL_HANDLER_AUX"
> >
>
> I made the stupid mistake of updating configure.in but not configure, so
> my first run showed no improvement at all :-(
>
> Fixing configure with the above change does cure all the regressions apart
> from a segmentaion fault when compiling simple.java (this is probably
> unrelated).
Ping....
Are you going to check this in?
R.