This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: Patch: tcp sockets: removing code duplication

From: Tom Tromey <tromey at redhat dot com>
To: Michael Koch <konqueror at gmx dot de>
Cc: java-patches at gcc dot gnu dot org
Date: 16 Mar 2004 20:30:38 -0700
Subject: Re: Patch: tcp sockets: removing code duplication
References: <200403111901.05651.konqueror@gmx.de><87y8q1ex3w.fsf@fleche.redhat.com><200403161015.47947.konqueror@gmx.de>
Reply-to: tromey at redhat dot com

>>>>> "Michael" == Michael Koch <konqueror@gmx.de> writes:

Michael> I have redone the patch. Can you take anohter look at it ?

This looks reasonable to me with one minor change...

Michael> +void write_helper (jint native_fd, jbyte *bytes, jint len);

This and read_helper should be `static'.

Tom

Follow-Ups:
- Re: Patch: tcp sockets: removing code duplication
  - From: Michael Koch

References:
- Patch: tcp sockets: removing code duplication
  - From: Michael Koch
- Re: Patch: tcp sockets: removing code duplication
  - From: Tom Tromey
- Re: Patch: tcp sockets: removing code duplication
  - From: Michael Koch

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]