Re: PATCH to optimize two Channels methods

["Richard dot Earnshaw at arm dot com" <rearnsha at arm dot com>]

> Am Dienstag, 9. März 2004 13:09 schrieb Richard Earnshaw:
> > > Am Dienstag, 9. März 2004 12:59 schrieb Richard Earnshaw:
> > > > konqueror@gmx.de said:
> > > > >  Another iteration of the patch as I forgot the include files.
> > > >
> > > > nope, still not there yet, I guess there's yet another header
> > > > file missing
> > >
> > > no, I did one type and forgot to delete something. Try the attached
> > > please. Sorry to need to bother you so much today.
> >
> > A bit better, but still not quite there yet...
> 
> hmm, hopefully much better now ...
> 

Nope:

gnu/java/nio/channels/natFileChannelImpl.cc:120: error: prototype for 
`jint gnu::java::nio::channels::FileChannelImpl::seek(jlong)' does not 
match any in class `gnu::java::nio::channels::FileChannelImpl'
./gnu/java/nio/channels/FileChannelImpl.h:58: error: candidate is: void 
gnu::java::nio::channels::FileChannelImpl::seek(jlong)
gnu/java/nio/channels/natFileChannelImpl.cc:120: error: `jint 
gnu::java::nio::channels::FileChannelImpl::seek(jlong)' and `void 
gnu::java::nio::channels::FileChannelImpl::seek(jlong)' cannot be 
overloaded
gnu/java/nio/channels/natFileChannelImpl.cc:156: error: prototype for 
`void gnu::java::nio::channels::FileChannelImpl::lock(jlong, jint, 
jboolean, jboolean)' does not match any in class `gnu::java::nio::channels:
:FileChannelImpl'
./gnu/java/nio/channels/FileChannelImpl.h:91: error: candidates are: 
virtual java::nio::channels::FileLock* gnu::java::nio::channels::FileChanne
lImpl::lock(jlong, jlong, jboolean)
./gnu/java/nio/channels/FileChannelImpl.h:89: error:                 
jboolean gnu::java::nio::channels::FileChannelImpl::lock(jlong, jlong, 
jboolean, jboolean)
gnu/java/nio/channels/natFileChannelImpl.cc:163: error: prototype for 
`void gnu::java::nio::channels::FileChannelImpl::unlock(jlong, jint)' does 
not match any in class `gnu::java::nio::channels::FileChannelImpl'
./gnu/java/nio/channels/FileChannelImpl.h:61: error: candidate is: virtual 
void gnu::java::nio::channels::FileChannelImpl::unlock(jlong, jlong)
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `jint 
gnu::java::nio::channels::FileChannelImpl::open(java::lang::String*, 
jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:86: warning: unused parameter 
'path'
gnu/java/nio/channels/natFileChannelImpl.cc:86: warning: unused parameter 
'jflags'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `jint 
gnu::java::nio::channels::FileChannelImpl::seek(jlong)':
gnu/java/nio/channels/natFileChannelImpl.cc:120: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `virtual 
jint gnu::java::nio::channels::FileChannelImpl::read(JArray<jbyte>*, jint, 
jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:144: warning: unused parameter 
'buffer'
gnu/java/nio/channels/natFileChannelImpl.cc:144: warning: unused parameter 
'offset'
gnu/java/nio/channels/natFileChannelImpl.cc:144: warning: unused parameter 
'count'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `void 
gnu::java::nio::channels::FileChannelImpl::lock(jlong, jint, jboolean, 
jboolean)':
gnu/java/nio/channels/natFileChannelImpl.cc:156: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:156: warning: unused parameter 
'len'
gnu/java/nio/channels/natFileChannelImpl.cc:156: warning: unused parameter 
'shared'
gnu/java/nio/channels/natFileChannelImpl.cc:156: warning: unused parameter 
'wait'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `void 
gnu::java::nio::channels::FileChannelImpl::unlock(jlong, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:163: warning: unused parameter 
'pos'
gnu/java/nio/channels/natFileChannelImpl.cc:163: warning: unused parameter 
'len'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `virtual 
java::nio::MappedByteBuffer* gnu::java::nio::channels::FileChannelImpl::map
Impl(jchar, jlong, jint)':
gnu/java/nio/channels/natFileChannelImpl.cc:170: warning: unused parameter 
'mmode'
gnu/java/nio/channels/natFileChannelImpl.cc:170: warning: unused parameter 
'position'
gnu/java/nio/channels/natFileChannelImpl.cc:170: warning: unused parameter 
'size'