This is the mail archive of the java-patches@gcc.gnu.org mailing list for the Java project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH to optimize two Channels methods


> I've checked in my java.nio patches, including the
> support for MappedByteBuffer.  This is a follow-up
> to optimize two of the helper methods in Channels,
> when the argument is a FileChannelImpl.  We should
> ideally do something similar for SocketChannels,
> but they don't seem to be implemented yet.
> 
> Tested on Fedora in mainline, include Mauve+Jacks.
> I'll check this in in a few days, to give people a
> chance to comment.
> -- 
> 	--Per Bothner
> per@bothner.com   http://per.bothner.com/
> 
> 
> 2004-03-01  Per Bothner  <per@bothner.com>
> 
> 	* java/nio/channels/Channels.java (newInputStream, newOutputStream):
> 	Optimize when argument is a FileChannelImpl.
> 	(newInputStream(FileChannelImpl), newOutputStream(FileChannelImpl)):
> 	New native methods.
> 	* java/nio/channels/natChannels.cc:  New file for new native methods.
> 	* Makefile.am:  Update accordingly.

Seems to be causing the following build error on arm-unknown-elf (with newlib):

/work/rearnsha/gnu/egcs/gcc/xgcc -shared-libgcc -B/work/rearnsha/gnu/egcs/gcc/ -nostdinc++ -L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src -L/work/rearnsha/gnu/egcs/arm-elf/thumb/libstdc++-v3/src/.libs -nostdinc -B/work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/ -isystem /work/rearnsha/gnu/egcs/arm-elf/thumb/newlib/targ-include -isystem /home/rearnsha/gnusrc/egcs-cross/newlib/libc/include -B/work/rearnsha/gnu/testinstall/arm-elf/bin/ -B/work/rearnsha/gnu/testinstall/arm-elf/lib/ -isystem /work/rearnsha/gnu/testinstall/arm-elf/include -isystem /work/rearnsha/gnu/testinstall/arm-elf/sys-include -L/work/rearnsha/gnu/egcs/ld -mthumb -DHAVE_CONFIG_H -I. -I/home/rearnsha/gnusrc/egcs-cross/libjava -I./include -I./gcj -I/home/rearnsha/gnusrc/egcs-cross/libjava -Iinclude -I/home/rearnsha/gnusrc/egcs-cross/libjava/include -I/home/rearnsha/gnusrc/egcs-cross/boehm-gc/include -DPACKAGE_NAME= -DPACKAGE_TARNAME= -DPACKAGE_VERSION= -DPACKAGE_STRING= -DPACKAGE_BUGREPORT= -DSTDC_HEADERS!
 =1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1 -DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_UNISTD_H=1 -DSILENT=1 -DNO_SIGNALS=1 -DALL_INTERIOR_POINTERS=1 -DJAVA_FINALIZATION=1 -DGC_GCJ_SUPPORT=1 -DATOMIC_UNCOLLECTABLE=1 -DNO_SIGSET=1 -DNO_DEBUGGING=1 -I/home/rearnsha/gnusrc/egcs-cross/libjava/.././libjava/../gcc -I/home/rearnsha/gnusrc/egcs-cross/libjava/../zlib -O2 -g -O2 -fno-rtti -fnon-call-exceptions -fdollars-in-identifiers -Wswitch-enum -I/usr/X11R6/include -W -Wall -D_GNU_SOURCE -DPREFIX=\"/work/rearnsha/gnu/testinstall\" -DLIBDIR=\"/work/rearnsha/gnu/testinstall/lib\" -DBOOT_CLASS_PATH=\"/work/rearnsha/gnu/testinstall/share/java/libgcj-3.5.0.jar\" -g -O2 -mthumb -MD -MT gnu/java/nio/channels/natFileChannelImpl.lo -MF gnu/java/nio/channels/natFileChannelImpl.pp -c gnu/java/nio/channels/natFileChannelImpl.cc -o gnu/java/nio/channels/natFileChannelImpl.o
gnu/java/nio/channels/natFileChannelImpl.cc:46: error: no `void java::io::FileDescriptor::init()' member function declared in class `java::io::FileDescriptor'
gnu/java/nio/channels/natFileChannelImpl.cc: In member function `void java::io::FileDescriptor::init()':
gnu/java/nio/channels/natFileChannelImpl.cc:48: error: invalid conversion from `int' to `java::nio::channels::ByteChannel*'
gnu/java/nio/channels/natFileChannelImpl.cc:48: error:   initializing argument 1 of `java::io::FileDescriptor::FileDescriptor(java::nio::channels::ByteChannel*)'
gnu/java/nio/channels/natFileChannelImpl.cc:49: error: invalid conversion from `int' to `java::nio::channels::ByteChannel*'
gnu/java/nio/channels/natFileChannelImpl.cc:49: error:   initializing argument 1 of `java::io::FileDescriptor::FileDescriptor(java::nio::channels::ByteChannel*)'
gnu/java/nio/channels/natFileChannelImpl.cc: At global scope:
gnu/java/nio/channels/natFileChannelImpl.cc:54: error: no `jboolean java::io::FileDescriptor::valid()' member function declared in class `java::io::FileDescriptor'
gnu/java/nio/channels/natFileChannelImpl.cc:54: error: `jboolean java::io::FileDescriptor::valid()' and `jboolean java::io::FileDescriptor::valid()' cannot be overloaded
gnu/java/nio/channels/natFileChannelImpl.cc:71: error: no `jint java::io::FileDescriptor::open(java::lang::String*, jint)' member function declared in class `java::io::FileDescriptor'
[...]


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]